Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #5460 from Snuffleupagus/limit-internal-scale-values-precision

Browse Source 
Prevent re-rendering of pages because of rounding errors when computing the scale value
This commit is contained in:
Tim van der Meij 2015-07-09 14:19:58 +02:00
commit ba38454865
1 changed files with 14 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
web/pdf_viewer.js
View File

@ -74,6 +74,18 @@ var PDFViewer = (function pdfViewer() {
}; };
} }
function isSameScale(oldScale, newScale) {
if (newScale === oldScale) {
return true;
}
if (Math.abs(newScale - oldScale) < 1e-15) {
// Prevent unnecessary re-rendering of all pages when the scale
// changes only because of limited numerical precision.
return true;
}
return false;
}
/** /**
* @constructs PDFViewer * @constructs PDFViewer
* @param {PDFViewerOptions} options * @param {PDFViewerOptions} options
@ -367,7 +379,8 @@ var PDFViewer = (function pdfViewer() {
_setScaleUpdatePages: function pdfViewer_setScaleUpdatePages( _setScaleUpdatePages: function pdfViewer_setScaleUpdatePages(
newScale, newValue, noScroll, preset) { newScale, newValue, noScroll, preset) {
this._currentScaleValue = newValue; this._currentScaleValue = newValue;
if (newScale === this._currentScale) {
if (isSameScale(this._currentScale, newScale)) {
if (preset) { if (preset) {
this._setScaleDispatchEvent(newScale, newValue, true); this._setScaleDispatchEvent(newScale, newValue, true);
} }