Address latest review comments by Artur
This commit is contained in:
parent
3142c2a7da
commit
b832aa5c1e
16
pdf.js
16
pdf.js
@ -3548,13 +3548,13 @@ var Page = (function pagePage() {
|
||||
// Firefox error reporting from XHR callbacks.
|
||||
setTimeout(function pageSetTimeout() {
|
||||
var exc = null;
|
||||
// try {
|
||||
try {
|
||||
self.display(gfx, continuation);
|
||||
// } catch (e) {
|
||||
// exc = e.toString();
|
||||
// continuation(exc);
|
||||
// throw e;
|
||||
// }
|
||||
} catch (e) {
|
||||
exc = e.toString();
|
||||
continuation(exc);
|
||||
throw e;
|
||||
}
|
||||
});
|
||||
};
|
||||
|
||||
@ -4564,6 +4564,7 @@ var PartialEvaluator = (function partialEvaluator() {
|
||||
getIRQueue: function partialEvaluatorGetIRQueue(stream, resources,
|
||||
queue, dependency) {
|
||||
|
||||
var self = this;
|
||||
var xref = this.xref;
|
||||
var handler = this.handler;
|
||||
var uniquePrefix = this.uniquePrefix;
|
||||
@ -4579,7 +4580,6 @@ var PartialEvaluator = (function partialEvaluator() {
|
||||
}
|
||||
}
|
||||
|
||||
var self = this;
|
||||
function handleSetFont(fontName, fontRef) {
|
||||
var loadedName = null;
|
||||
|
||||
@ -5389,7 +5389,7 @@ function ScratchCanvas(width, height) {
|
||||
}
|
||||
|
||||
var CanvasGraphics = (function canvasGraphics() {
|
||||
// Defines the time the executeIRQueue gone be executing
|
||||
// Defines the time the executeIRQueue gonna be executing
|
||||
// before it stops and shedules a continue of execution.
|
||||
var kExecutionTime = 50;
|
||||
// Number of IR commands to execute before checking
|
||||
|
12
worker.js
12
worker.js
@ -7,8 +7,8 @@
|
||||
var useWorker = false;
|
||||
|
||||
var WorkerPage = (function() {
|
||||
function constructor(workerPDF, page, objs) {
|
||||
this.workerPDF = workerPDF;
|
||||
function constructor(pdf, page, objs) {
|
||||
this.pdf = pdf;
|
||||
this.page = page;
|
||||
this.objs = objs;
|
||||
|
||||
@ -39,7 +39,7 @@ var WorkerPage = (function() {
|
||||
// this.page.startRendering(ctx, callback, errback);
|
||||
|
||||
this.startRenderingTime = Date.now();
|
||||
this.workerPDF.startRendering(this);
|
||||
this.pdf.startRendering(this);
|
||||
},
|
||||
|
||||
startRenderingFromIRQueue: function(IRQueue, fonts) {
|
||||
@ -53,7 +53,9 @@ var WorkerPage = (function() {
|
||||
console.log('page=%d - total time: time=%dms',
|
||||
pageNum, Date.now() - this.startRenderingTime);
|
||||
|
||||
this.callback(err);
|
||||
if (this.callback) {
|
||||
this.callback(err);
|
||||
}
|
||||
}.bind(this);
|
||||
this.page.startRenderingFromIRQueue(gfx, IRQueue, fonts, callback);
|
||||
},
|
||||
@ -165,7 +167,7 @@ var PDFObjects = (function() {
|
||||
* Sets the data of an object but *doesn't* resolve it.
|
||||
*/
|
||||
setData: function(objId, data) {
|
||||
// Watchout! If you call `this.ensureObj(objId, data)` you'll gone create
|
||||
// Watchout! If you call `this.ensureObj(objId, data)` you'll gonna create
|
||||
// a *resolved* promise which shouldn't be the case!
|
||||
this.ensureObj(objId).data = data;
|
||||
}
|
||||
|
@ -33,24 +33,6 @@ var WorkerProcessorHandler = {
|
||||
console.log('page=%d - getIRQueue: time=%dms, len=%d', pageNum,
|
||||
Date.now() - start, IRQueue.fnArray.length);
|
||||
|
||||
if (false /* show used commands */) {
|
||||
var cmdMap = {};
|
||||
|
||||
var fnArray = IRQueue .fnArray;
|
||||
for (var i = 0; i < fnArray.length; i++) {
|
||||
var entry = fnArray[i];
|
||||
if (entry == 'paintReadyFormXObject') {
|
||||
//console.log(preCompilation.argsArray[i]);
|
||||
}
|
||||
if (cmdMap[entry] == null) {
|
||||
cmdMap[entry] = 1;
|
||||
} else {
|
||||
cmdMap[entry] += 1;
|
||||
}
|
||||
}
|
||||
console.log('cmds', JSON.stringify(cmdMap));
|
||||
}
|
||||
|
||||
// Filter the dependecies for fonts.
|
||||
var fonts = {};
|
||||
for (var i = 0; i < dependency.length; i++) {
|
||||
|
Loading…
Reference in New Issue
Block a user