Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[Editor] Avoid to add a cancelled added image in the undo/redo stack

Browse Source 
We're adding the action in the undo/redo stack whatever the status of the
operation was. This patch aims to add the action only when the image has been
successfully added.
This commit is contained in:
Calixte Denizet 2023-08-10 12:17:27 +02:00
parent f89020e9b1
commit b6432ef9de
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/display/editor/stamp.js
View File

@ -38,6 +38,8 @@ class StampEditor extends AnnotationEditor {
#isSvg = false; #isSvg = false;
#hasBeenAddedInUndoStack = false;
static _type = "stamp"; static _type = "stamp";
constructor(params) { constructor(params) {
@ -178,7 +180,6 @@ class StampEditor extends AnnotationEditor {
/** @inheritdoc */ /** @inheritdoc */
onceAdded() { onceAdded() {
this._isDraggable = true; this._isDraggable = true;
this.parent.addUndoableEditor(this);
this.div.focus(); this.div.focus();
} }
@ -263,6 +264,10 @@ class StampEditor extends AnnotationEditor {
this.#drawBitmap(width, height); this.#drawBitmap(width, height);
this.#createObserver(); this.#createObserver();
div.classList.remove("loading"); div.classList.remove("loading");
if (!this.#hasBeenAddedInUndoStack) {
this.parent.addUndoableEditor(this);
this.#hasBeenAddedInUndoStack = true;
}
} }
/** /**