Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #12993 from Snuffleupagus/metadata-subject

Browse Source 
[api-minor] Change the `dc:subject` Metadata field to an Array
This commit is contained in:
Tim van der Meij 2021-02-15 20:27:34 +01:00 committed by GitHub
commit b5735f2017
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 14 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
src/display/metadata.js
View File

@ -89,23 +89,18 @@ class Metadata {
return entry.childNodes.filter(node => node.nodeName === "rdf:li"); return entry.childNodes.filter(node => node.nodeName === "rdf:li");
} }
_getCreators(entry) { _parseArray(entry) {
if (entry.nodeName !== "dc:creator") {
return false;
}
if (!entry.hasChildNodes()) { if (!entry.hasChildNodes()) {
return true; return;
} }
// Child must be a Bag (unordered array) or a Seq. // Child must be a Bag (unordered array) or a Seq.
const seqNode = entry.childNodes[0]; const [seqNode] = entry.childNodes;
const authors = this._getSequence(seqNode) || []; const sequence = this._getSequence(seqNode) || [];
this._metadataMap.set( this._metadataMap.set(
entry.nodeName, entry.nodeName,
authors.map(node => node.textContent.trim()) sequence.map(node => node.textContent.trim())
); );
return true;
} }
_parse(xmlDocument) { _parse(xmlDocument) {
@ -130,11 +125,13 @@ class Metadata {
for (const entry of desc.childNodes) { for (const entry of desc.childNodes) {
const name = entry.nodeName; const name = entry.nodeName;
if (name === "#text") { switch (name) {
continue; case "#text":
} continue;
if (this._getCreators(entry)) { case "dc:creator":
continue; case "dc:subject":
this._parseArray(entry);
continue;
} }
this._metadataMap.set(name, entry.textContent.trim()); this._metadataMap.set(name, entry.textContent.trim());
} }

2
test/unit/metadata_spec.js
View File

@ -171,7 +171,7 @@ describe("metadata", function () {
"dc:creator": [""], "dc:creator": [""],
"dc:description": "", "dc:description": "",
"dc:format": "application/pdf", "dc:format": "application/pdf",
"dc:subject": "", "dc:subject": [],
"dc:title": "", "dc:title": "",
"pdf:keywords": "", "pdf:keywords": "",
"pdf:pdfversion": "1.7", "pdf:pdfversion": "1.7",