Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

In getVisibleElements, check firstVisibleElementInd rather than numViews before backtracking (PR 10443 follow-up)

Browse Source 
When `firstVisibleElementInd === 0`, regardless of the number of views, there's no reason to attempt to backtrack at all since it's never possible to find an element before the *first* one anyway.
This commit is contained in:
Jonas Jenwald 2019-01-27 14:50:16 +01:00
parent 40863eb275
commit b50a512660
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
web/ui_utils.js
View File

@ -446,7 +446,8 @@ function getVisibleElements(scrollEl, views, sortByVisibility = false,
// Please note the return value of the `binarySearchFirstItem` function when // Please note the return value of the `binarySearchFirstItem` function when
// no valid element is found (hence the `firstVisibleElementInd` check below). // no valid element is found (hence the `firstVisibleElementInd` check below).
if (numViews > 0 && firstVisibleElementInd < numViews && !horizontal) { if (firstVisibleElementInd > 0 && firstVisibleElementInd < numViews &&
!horizontal) {
// In wrapped scrolling (or vertical scrolling with spreads), with some page // In wrapped scrolling (or vertical scrolling with spreads), with some page
// sizes, isElementBottomAfterViewTop doesn't satisfy the binary search // sizes, isElementBottomAfterViewTop doesn't satisfy the binary search
// condition: there can be pages with bottoms above the view top between // condition: there can be pages with bottoms above the view top between