From b420f0165a0e776923c77431c14b7ca87944e12c Mon Sep 17 00:00:00 2001 From: Jonas Jenwald Date: Sat, 24 Sep 2022 15:02:12 +0200 Subject: [PATCH] Use `stopImmediatePropagation` without checking for its existence first These checks were added years ago, but given the following compatibility data we should just be able to call the method directly: https://developer.mozilla.org/en-US/docs/Web/API/Event/stopImmediatePropagation#browser_compatibility --- web/pdf_print_service.js | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/web/pdf_print_service.js b/web/pdf_print_service.js index 4d6bdf976..87cc73c62 100644 --- a/web/pdf_print_service.js +++ b/web/pdf_print_service.js @@ -314,14 +314,8 @@ window.addEventListener( ) { window.print(); - // The (browser) print dialog cannot be prevented from being shown in - // IE11. event.preventDefault(); - if (event.stopImmediatePropagation) { - event.stopImmediatePropagation(); - } else { - event.stopPropagation(); - } + event.stopImmediatePropagation(); } }, true @@ -331,7 +325,7 @@ if ("onbeforeprint" in window) { // Do not propagate before/afterprint events when they are not triggered // from within this polyfill. (FF / Chrome 63+). const stopPropagationIfNeeded = function (event) { - if (event.detail !== "custom" && event.stopImmediatePropagation) { + if (event.detail !== "custom") { event.stopImmediatePropagation(); } };