RFC 3986-compliant isValidUrl (protocol parsing)

To avoid misinterpreting URLs like "/File:wikipedia.png" as a
non-relative URLs.
This commit is contained in:
Rob Wu 2014-01-22 12:39:42 +01:00
parent 3c0b8073be
commit b35ced8c9e

View File

@ -223,7 +223,7 @@ var UnsupportedManager = PDFJS.UnsupportedManager =
function combineUrl(baseUrl, url) {
if (!url)
return baseUrl;
if (url.indexOf(':') >= 0)
if (/^[a-z][a-z0-9+\-.]*:/i.test(url))
return url;
if (url.charAt(0) == '/') {
// absolute path
@ -247,11 +247,13 @@ function isValidUrl(url, allowRelative) {
if (!url) {
return false;
}
var colon = url.indexOf(':');
if (colon < 0) {
// RFC 3986 (http://tools.ietf.org/html/rfc3986#section-3.1)
// scheme = ALPHA *( ALPHA / DIGIT / "+" / "-" / "." )
var protocol = /^[a-z][a-z0-9+\-.]*(?=:)/i.exec(url);
if (!protocol) {
return allowRelative;
}
var protocol = url.substr(0, colon);
protocol = protocol[0].toLowerCase();
switch (protocol) {
case 'http':
case 'https':