Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Avoid more allocations for RTL text in bidi.js

Browse Source 
Instead of building the resulting string char-by-char for RTL text, which is inefficient, we can just as well `join` the `chars` array.
This commit is contained in:
Jonas Jenwald 2015-08-14 15:49:39 +02:00
parent 88bf19396e
commit b1cf4d98ad
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/core/bidi.js
View File

@ -412,14 +412,13 @@ var bidi = PDFJS.bidi = (function bidiClosure() {
// don't mirror as characters are already mirrored in the pdf // don't mirror as characters are already mirrored in the pdf
// Finally, return string // Finally, return string
var result = '';
for (i = 0, ii = chars.length; i < ii; ++i) { for (i = 0, ii = chars.length; i < ii; ++i) {
var ch = chars[i]; var ch = chars[i];
if (ch !== '<' && ch !== '>') { if (ch === '<' || ch === '>') {
result += ch; chars[i] = '';
} }
} }
return createBidiText(result, isLTR); return createBidiText(chars.join(''), isLTR);
} }
return bidi; return bidi;