Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Refactoring thumbnail scroll code to fix jumps

Browse Source
This commit is contained in:
Tim van der Meij 2013-10-09 20:40:21 +02:00
parent cdcc26eedf
commit b1b661a274
2 changed files with 14 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
web/viewer.css
View File

@ -1078,6 +1078,11 @@ html[dir='rtl'] .verticalToolbarSeparator {
.thumbnail { .thumbnail {
float: left; float: left;
margin-bottom: 5px;
}
#thumbnailView > a:last-of-type > .thumbnail {
margin-bottom: 10px;
} }
.thumbnail:not([data-loaded]) { .thumbnail:not([data-loaded]) {

16
web/viewer.js
View File

@ -35,6 +35,7 @@ var MAX_SCALE = 4.0;
var SETTINGS_MEMORY = 20; var SETTINGS_MEMORY = 20;
var SCALE_SELECT_CONTAINER_PADDING = 8; var SCALE_SELECT_CONTAINER_PADDING = 8;
var SCALE_SELECT_PADDING = 22; var SCALE_SELECT_PADDING = 22;
var THUMBNAIL_SCROLL_MARGIN = -19;
var USE_ONLY_CSS_ZOOM = false; var USE_ONLY_CSS_ZOOM = false;
//#if B2G //#if B2G
//USE_ONLY_CSS_ZOOM = true; //USE_ONLY_CSS_ZOOM = true;
@ -1854,22 +1855,23 @@ window.addEventListener('pagechange', function pagechange(evt) {
if (PDFView.previousPageNumber !== page) { if (PDFView.previousPageNumber !== page) {
document.getElementById('pageNumber').value = page; document.getElementById('pageNumber').value = page;
var selected = document.querySelector('.thumbnail.selected'); var selected = document.querySelector('.thumbnail.selected');
if (selected) if (selected) {
selected.classList.remove('selected'); selected.classList.remove('selected');
}
var thumbnail = document.getElementById('thumbnailContainer' + page); var thumbnail = document.getElementById('thumbnailContainer' + page);
thumbnail.classList.add('selected'); thumbnail.classList.add('selected');
var visibleThumbs = PDFView.getVisibleThumbs(); var visibleThumbs = PDFView.getVisibleThumbs();
var numVisibleThumbs = visibleThumbs.views.length; var numVisibleThumbs = visibleThumbs.views.length;
// If the thumbnail isn't currently visible scroll it into view.
// If the thumbnail isn't currently visible, scroll it into view.
if (numVisibleThumbs > 0) { if (numVisibleThumbs > 0) {
var first = visibleThumbs.first.id; var first = visibleThumbs.first.id;
// Account for only one thumbnail being visible. // Account for only one thumbnail being visible.
var last = numVisibleThumbs > 1 ? var last = (numVisibleThumbs > 1 ? visibleThumbs.last.id : first);
visibleThumbs.last.id : first; if (page <= first || page >= last) {
if (page <= first || page >= last) scrollIntoView(thumbnail, { top: THUMBNAIL_SCROLL_MARGIN });
scrollIntoView(thumbnail); }
} }
} }
document.getElementById('previous').disabled = (page <= 1); document.getElementById('previous').disabled = (page <= 1);
document.getElementById('next').disabled = (page >= PDFView.pages.length); document.getElementById('next').disabled = (page >= PDFView.pages.length);