From b068882bd00e015924601887a8e897c7f63678c9 Mon Sep 17 00:00:00 2001
From: Jonas Jenwald <jonas.jenwald@gmail.com>
Date: Tue, 11 May 2021 12:39:33 +0200
Subject: [PATCH] Clean-up usage of the `TESTING`-define in
 `src/pdf.sandbox.js`

This patch moves the `PDFJSDev`-checks *inline*, similar to the rest of the code-base, such that the code in question is actually being removed from the *built* files in e.g. the official releases.
---
 src/pdf.sandbox.js | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/src/pdf.sandbox.js b/src/pdf.sandbox.js
index 1172895c0..1a1140c39 100644
--- a/src/pdf.sandbox.js
+++ b/src/pdf.sandbox.js
@@ -21,9 +21,6 @@ const pdfjsVersion = PDFJSDev.eval("BUNDLE_VERSION");
 /* eslint-disable-next-line no-unused-vars */
 const pdfjsBuild = PDFJSDev.eval("BUNDLE_BUILD");
 
-const TESTING =
-  typeof PDFJSDev === "undefined" || PDFJSDev.test("!PRODUCTION || TESTING");
-
 class SandboxSupport extends SandboxSupportBase {
   exportValueToSandbox(val) {
     // The communication with the Quickjs sandbox is based on strings
@@ -58,16 +55,17 @@ class Sandbox {
   }
 
   create(data) {
-    if (TESTING) {
+    if (PDFJSDev.test("!PRODUCTION || TESTING")) {
       this._module.ccall("nukeSandbox", null, []);
     }
     const code = [PDFJSDev.eval("PDF_SCRIPTING_JS_SOURCE")];
-    if (!TESTING) {
-      code.push("delete dump;");
-    } else {
+
+    if (PDFJSDev.test("!PRODUCTION || TESTING")) {
       code.push(
         `globalThis.sendResultForTesting = callExternalFunction.bind(null, "send");`
       );
+    } else {
+      code.push("delete dump;");
     }
 
     let success = false;
@@ -124,7 +122,7 @@ class Sandbox {
   }
 
   evalForTesting(code, key) {
-    if (TESTING) {
+    if (PDFJSDev.test("!PRODUCTION || TESTING")) {
       this._module.ccall(
         "evalInSandbox",
         null,
@@ -138,6 +136,8 @@ class Sandbox {
           this._alertOnError,
         ]
       );
+    } else {
+      throw new Error("Not implemented: evalForTesting");
     }
   }
 }