Merge pull request #10968 from Snuffleupagus/MessageHandler-rm-useless-wrapReason

Remove useless `wrapReason` calls in the `MessageHandler` class
This commit is contained in:
Tim van der Meij 2019-07-13 14:30:02 +02:00 committed by GitHub
commit b01cc55cfd
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -52,11 +52,11 @@ function makeReasonSerializable(reason) {
return new UnknownErrorException(reason.message, reason.toString()); return new UnknownErrorException(reason.message, reason.toString());
} }
function resolveOrReject(capability, success, reason) { function resolveOrReject(capability, data) {
if (success) { if (data.success) {
capability.resolve(); capability.resolve();
} else { } else {
capability.reject(reason); capability.reject(wrapReason(data.reason));
} }
} }
@ -341,12 +341,10 @@ MessageHandler.prototype = {
switch (data.stream) { switch (data.stream) {
case 'start_complete': case 'start_complete':
resolveOrReject(this.streamControllers[data.streamId].startCall, resolveOrReject(this.streamControllers[data.streamId].startCall, data);
data.success, wrapReason(data.reason));
break; break;
case 'pull_complete': case 'pull_complete':
resolveOrReject(this.streamControllers[data.streamId].pullCall, resolveOrReject(this.streamControllers[data.streamId].pullCall, data);
data.success, wrapReason(data.reason));
break; break;
case 'pull': case 'pull':
// Ignore any pull after close is called. // Ignore any pull after close is called.
@ -395,8 +393,7 @@ MessageHandler.prototype = {
deleteStreamController(); deleteStreamController();
break; break;
case 'cancel_complete': case 'cancel_complete':
resolveOrReject(this.streamControllers[data.streamId].cancelCall, resolveOrReject(this.streamControllers[data.streamId].cancelCall, data);
data.success, wrapReason(data.reason));
deleteStreamController(); deleteStreamController();
break; break;
case 'cancel': case 'cancel':