Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Try to remove the mozOpaque canvas-property (PR 6551 follow-up)

Browse Source 
According to MDN, see https://developer.mozilla.org/en-US/docs/Web/API/HTMLCanvasElement/mozOpaque, the `mozOpaque` canvas-property is not only non-standard (obviously) but it's also been deprecated.
Instead it's recommended to use `alpha = false` when getting the canvas-context, see https://developer.mozilla.org/en-US/docs/Web/API/HTMLCanvasElement/getContext#contextattributes, which all of our affected code is already doing.
This commit is contained in:
Jonas Jenwald 2022-05-09 12:25:51 +02:00
parent 38c82357b2
commit af5789125f
5 changed files with 0 additions and 34 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/display/text_layer.js
View File

@ -730,12 +730,6 @@ class TextLayerRenderTask {
const canvas = this._document.createElement("canvas"); const canvas = this._document.createElement("canvas");
canvas.height = canvas.width = DEFAULT_FONT_SIZE; canvas.height = canvas.width = DEFAULT_FONT_SIZE;
if (
typeof PDFJSDev === "undefined" ||
PDFJSDev.test("MOZCENTRAL || GENERIC")
) {
canvas.mozOpaque = true;
}
this._layoutTextCtx = canvas.getContext("2d", { alpha: false }); this._layoutTextCtx = canvas.getContext("2d", { alpha: false });
if (this._textContent) { if (this._textContent) {

1
test/driver.js
View File

@ -607,7 +607,6 @@ class Driver {
this._log( this._log(
" Loading page " + task.pageNum + "/" + task.pdfDoc.numPages + "... " " Loading page " + task.pageNum + "/" + task.pdfDoc.numPages + "... "
); );
this.canvas.mozOpaque = true;
ctx = this.canvas.getContext("2d", { alpha: false }); ctx = this.canvas.getContext("2d", { alpha: false });
task.pdfDoc.getPage(task.pageNum).then( task.pdfDoc.getPage(task.pageNum).then(
page => { page => {

7
web/pdf_page_view.js
View File

@ -783,13 +783,6 @@ class PDFPageView {
canvasWrapper.appendChild(canvas); canvasWrapper.appendChild(canvas);
this.canvas = canvas; this.canvas = canvas;
if (
typeof PDFJSDev === "undefined" ||
PDFJSDev.test("MOZCENTRAL || GENERIC")
) {
canvas.mozOpaque = true;
}
const ctx = canvas.getContext("2d", { alpha: false }); const ctx = canvas.getContext("2d", { alpha: false });
const outputScale = (this.outputScale = new OutputScale()); const outputScale = (this.outputScale = new OutputScale());

14
web/pdf_thumbnail_view.js
View File

@ -51,13 +51,6 @@ class TempImageFactory {
// Since this is a temporary canvas, we need to fill it with a white // Since this is a temporary canvas, we need to fill it with a white
// background ourselves. `_getPageDrawContext` uses CSS rules for this. // background ourselves. `_getPageDrawContext` uses CSS rules for this.
if (
typeof PDFJSDev === "undefined" ||
PDFJSDev.test("MOZCENTRAL || GENERIC")
) {
tempCanvas.mozOpaque = true;
}
const ctx = tempCanvas.getContext("2d", { alpha: false }); const ctx = tempCanvas.getContext("2d", { alpha: false });
ctx.save(); ctx.save();
ctx.fillStyle = "rgb(255, 255, 255)"; ctx.fillStyle = "rgb(255, 255, 255)";
@ -225,13 +218,6 @@ class PDFThumbnailView {
// Keep the no-thumbnail outline visible, i.e. `data-loaded === false`, // Keep the no-thumbnail outline visible, i.e. `data-loaded === false`,
// until rendering/image conversion is complete, to avoid display issues. // until rendering/image conversion is complete, to avoid display issues.
const canvas = document.createElement("canvas"); const canvas = document.createElement("canvas");
if (
typeof PDFJSDev === "undefined" ||
PDFJSDev.test("MOZCENTRAL || GENERIC")
) {
canvas.mozOpaque = true;
}
const ctx = canvas.getContext("2d", { alpha: false }); const ctx = canvas.getContext("2d", { alpha: false });
const outputScale = new OutputScale(); const outputScale = new OutputScale();

6
web/toolbar.js
View File

@ -261,12 +261,6 @@ class Toolbar {
// The temporary canvas is used to measure text length in the DOM. // The temporary canvas is used to measure text length in the DOM.
let canvas = document.createElement("canvas"); let canvas = document.createElement("canvas");
if (
typeof PDFJSDev === "undefined" ||
PDFJSDev.test("MOZCENTRAL || GENERIC")
) {
canvas.mozOpaque = true;
}
let ctx = canvas.getContext("2d", { alpha: false }); let ctx = canvas.getContext("2d", { alpha: false });
await animationStarted; await animationStarted;