From 7d7a8a1a3ce47fbcd72c57efd98639e451275e5b Mon Sep 17 00:00:00 2001
From: Jonas Jenwald <jonas.jenwald@gmail.com>
Date: Fri, 16 Apr 2021 09:40:26 +0200
Subject: [PATCH 1/2] [GENERIC viewer] Don't display the `errorWrapper`, for
documents with signatures (PR 13217 follow-up)
According to a decision by UX and PM, please see https://bugzilla.mozilla.org/show_bug.cgi?id=1705060#c2, in Firefox we should first of all *not* display the notification-bar for signatures. Secondly, as can also be seen there, we shouldn't display the notification-bar *at all* and it's thus disabled in https://bugzilla.mozilla.org/show_bug.cgi?id=1705327.
If we purposely don't display a notification, for documents with signatures, in the *built in* Firefox PDF Viewer then it cannot be necessary in the GENERIC viewer either.
---
l10n/en-US/viewer.properties | 3 ---
web/app.js | 10 ----------
web/l10n_utils.js | 2 --
3 files changed, 15 deletions(-)
diff --git a/l10n/en-US/viewer.properties b/l10n/en-US/viewer.properties
index 1a7b908eb..5fe094b76 100644
--- a/l10n/en-US/viewer.properties
+++ b/l10n/en-US/viewer.properties
@@ -246,6 +246,3 @@ password_cancel=Cancel
printing_not_supported=Warning: Printing is not fully supported by this browser.
printing_not_ready=Warning: The PDF is not fully loaded for printing.
web_fonts_disabled=Web fonts are disabled: unable to use embedded PDF fonts.
-# LOCALIZATION NOTE (unsupported_feature_signatures): Should contain the same
-# exact string as in the `chrome.properties` file.
-unsupported_feature_signatures=This PDF document contains digital signatures. Validation of signatures is not supported.
diff --git a/web/app.js b/web/app.js
index 6d74eb6c3..f8e817dd4 100644
--- a/web/app.js
+++ b/web/app.js
@@ -1062,16 +1062,6 @@ const PDFViewerApplication = {
}
this._fellback = true;
- // Ensure that, for signatures, a warning is shown in non-Firefox builds.
- if (
- (typeof PDFJSDev === "undefined" || !PDFJSDev.test("MOZCENTRAL")) &&
- featureId === UNSUPPORTED_FEATURES.signatures
- ) {
- this.l10n.get("unsupported_feature_signatures").then(msg => {
- this._otherError(msg);
- });
- }
-
this.externalServices
.fallback({
featureId,
diff --git a/web/l10n_utils.js b/web/l10n_utils.js
index ef3d21c11..04e8a549d 100644
--- a/web/l10n_utils.js
+++ b/web/l10n_utils.js
@@ -81,8 +81,6 @@ const DEFAULT_L10N_STRINGS = {
printing_not_ready: "Warning: The PDF is not fully loaded for printing.",
web_fonts_disabled:
"Web fonts are disabled: unable to use embedded PDF fonts.",
- unsupported_feature_signatures:
- "This PDF document contains digital signatures. Validation of signatures is not supported.",
};
function getL10nFallback(key, args) {
From a6e29ab43c9b9b6b8ebb82e79bb0b6daf9e60216 Mon Sep 17 00:00:00 2001
From: Jonas Jenwald <jonas.jenwald@gmail.com>
Date: Fri, 16 Apr 2021 09:49:11 +0200
Subject: [PATCH 2/2] Remove the special handling of "errorFontLoadNative" and
"errorFontMissing" in `PDFViewerApplication.fallback` (PR 12931 follow-up, PR
12995 follow-up)
According to a decision by UX and PM, please see https://bugzilla.mozilla.org/show_bug.cgi?id=1705060#c2 (and implemented in https://bugzilla.mozilla.org/show_bug.cgi?id=1705327), we no longer show the notification-bar in Firefox.
Hence there's (obviously) no need to ignore certain `featureId`s in `PDFViewerApplication.fallback` anymore.
---
web/app.js | 7 -------
1 file changed, 7 deletions(-)
diff --git a/web/app.js b/web/app.js
index f8e817dd4..8bbe331cb 100644
--- a/web/app.js
+++ b/web/app.js
@@ -1048,13 +1048,6 @@ const PDFViewerApplication = {
featureId,
});
- // Don't show the fallback bar for things that are *very* unlikely to cause
- // user-visible errors, to avoid bothering the user unnecessarily.
- switch (featureId) {
- case UNSUPPORTED_FEATURES.errorFontLoadNative:
- case UNSUPPORTED_FEATURES.errorFontMissing:
- return;
- }
// Only trigger the fallback once so we don't spam the user with messages
// for one PDF.
if (this._fellback) {