Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Handle errors in the "Loading by ref" code-path in PartialEvaluator.loadFont

Browse Source 
Note how we currently throw a "raw" Error, which is problematical since all of the `PartialEvaluator.loadFont` call-sites expect a Promise to be returned. Furthermore, this also means that we don't benefit from the fallback code-path that now exists below.

*Please note:* Unfortunately I don't have a test-case that fails without this patch, since it's something I happened to notice when reading the code while working on another patch.
This commit is contained in:
Jonas Jenwald 2022-07-15 13:32:08 +02:00
parent 3256761ead
commit acd61a138e
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/core/evaluator.js
View File

@ -1176,10 +1176,9 @@ class PartialEvaluator {
let fontRef; let fontRef;
if (font) { if (font) {
// Loading by ref. // Loading by ref.
if (!(font instanceof Ref)) { if (font instanceof Ref) {
throw new FormatError('The "font" object should be a reference.'); fontRef = font;
} }
fontRef = font;
} else { } else {
// Loading by name. // Loading by name.
const fontRes = resources.get("Font"); const fontRes = resources.get("Font");