Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Slightly simplify the Catalog._readMarkInfo method

Browse Source 
We don't need to first check if the Dictionary contains the key, since trying to get a non-existent key simply returns `undefined` and we're already ensuring that the value is a boolean.
Furthermore, we shouldn't need to worry about the `Object.prototype` containing enumerable properties since the checks (in `src/core/worker.js`) done for `Array.prototype` *indirectly* also cover `Object`s. (Keep in mind that an `Array` is just a special kind of `Object` in JavaScript.)
This commit is contained in:
Jonas Jenwald 2022-04-05 16:04:09 +02:00
parent 1dc4713a0b
commit a919959d83
1 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/core/catalog.js
View File

@ -209,20 +209,16 @@ class Catalog {
return null; return null;
} }
const markInfo = Object.assign(Object.create(null), { const markInfo = {
Marked: false, Marked: false,
UserProperties: false, UserProperties: false,
Suspects: false, Suspects: false,
}); };
for (const key in markInfo) { for (const key in markInfo) {
if (!obj.has(key)) {
continue;
}
const value = obj.get(key); const value = obj.get(key);
if (typeof value !== "boolean") { if (typeof value === "boolean") {
continue; markInfo[key] = value;
} }
markInfo[key] = value;
} }
return markInfo; return markInfo;