Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #7965 from Snuffleupagus/bug-1331081

Browse Source 
[Bug 1331081] omit addEventListener/removeEventListener's third parameter when it's false
This commit is contained in:
Tim van der Meij 2017-01-17 22:26:26 +01:00 committed by GitHub
commit a917443ae6
4 changed files with 12 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
web/debugger.js
View File

@ -403,13 +403,13 @@ var Stepper = (function StepperClosure() {
var listener = function(e) { var listener = function(e) {
switch (e.keyCode) { switch (e.keyCode) {
case 83: // step case 83: // step
dom.removeEventListener('keydown', listener, false); dom.removeEventListener('keydown', listener);
self.nextBreakPoint = self.currentIdx + 1; self.nextBreakPoint = self.currentIdx + 1;
self.goTo(-1); self.goTo(-1);
callback(); callback();
break; break;
case 67: // continue case 67: // continue
dom.removeEventListener('keydown', listener, false); dom.removeEventListener('keydown', listener);
var breakPoint = self.getNextBreakPoint(); var breakPoint = self.getNextBreakPoint();
self.nextBreakPoint = breakPoint; self.nextBreakPoint = breakPoint;
self.goTo(-1); self.goTo(-1);
@ -417,7 +417,7 @@ var Stepper = (function StepperClosure() {
break; break;
} }
}; };
dom.addEventListener('keydown', listener, false); dom.addEventListener('keydown', listener);
self.goTo(idx); self.goTo(idx);
}, },
goTo: function goTo(idx) { goTo: function goTo(idx) {

4
web/firefoxcom.js
View File

@ -76,9 +76,9 @@ var FirefoxCom = (function FirefoxComClosure() {
document.documentElement.removeChild(node); document.documentElement.removeChild(node);
document.removeEventListener('pdf.js.response', listener, false); document.removeEventListener('pdf.js.response', listener);
return callback(response); return callback(response);
}, false); });
} }
document.documentElement.appendChild(request); document.documentElement.appendChild(request);

11
web/pdf_history.js
View File

@ -114,7 +114,7 @@
} else { } else {
updateHistoryWithCurrentHash(); updateHistoryWithCurrentHash();
} }
}, false); });
function updateHistoryWithCurrentHash() { function updateHistoryWithCurrentHash() {
@ -162,18 +162,17 @@
} }
// Remove the event listener when navigating away from the document, // Remove the event listener when navigating away from the document,
// since 'beforeunload' prevents Firefox from caching the document. // since 'beforeunload' prevents Firefox from caching the document.
window.removeEventListener('beforeunload', pdfHistoryBeforeUnload, window.removeEventListener('beforeunload', pdfHistoryBeforeUnload);
false);
} }
window.addEventListener('beforeunload', pdfHistoryBeforeUnload, false); window.addEventListener('beforeunload', pdfHistoryBeforeUnload);
window.addEventListener('pageshow', function pdfHistoryPageShow(evt) { window.addEventListener('pageshow', function pdfHistoryPageShow(evt) {
// If the entire viewer (including the PDF file) is cached in // If the entire viewer (including the PDF file) is cached in
// the browser, we need to reattach the 'beforeunload' event listener // the browser, we need to reattach the 'beforeunload' event listener
// since the 'DOMContentLoaded' event is not fired on 'pageshow'. // since the 'DOMContentLoaded' event is not fired on 'pageshow'.
window.addEventListener('beforeunload', pdfHistoryBeforeUnload, false); window.addEventListener('beforeunload', pdfHistoryBeforeUnload);
}, false); });
self.eventBus.on('presentationmodechanged', function(e) { self.eventBus.on('presentationmodechanged', function(e) {
self.isViewerInPresentationMode = e.active; self.isViewerInPresentationMode = e.active;

4
web/pdf_print_service.js
View File

@ -320,8 +320,8 @@
event.stopImmediatePropagation(); event.stopImmediatePropagation();
} }
}; };
window.addEventListener('beforeprint', stopPropagationIfNeeded, false); window.addEventListener('beforeprint', stopPropagationIfNeeded);
window.addEventListener('afterprint', stopPropagationIfNeeded, false); window.addEventListener('afterprint', stopPropagationIfNeeded);
} }
var overlayPromise; var overlayPromise;