Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove unnecessary startedTextExtraction member variable from the find controller

Browse Source 
The find controller already has quite a lot of state to maintain. We can
avoid keeping track of this member variable because when the find
controller is reset, so is the extract text promises array. Therefore,
we can just check if that array contains items or not to determine if
text extraction already started.

Moreover, there is no need to reset the `pageContents` array since the
`reset` method already takes care of that.
This commit is contained in:
Tim van der Meij 2018-09-11 20:14:57 +02:00
parent 21d959bb82
commit a859f0eafd
No known key found for this signature in database
GPG Key ID: 8C3FD2925A5F2762
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
web/pdf_find_controller.js
View File

@ -62,7 +62,6 @@ class PDFFindController {
}
reset() {
this.startedTextExtraction = false;
this.extractTextPromises = [];
this.pendingFindMatches = Object.create(null);
this.active = false; // If active, find results will be highlighted.
@ -309,11 +308,10 @@ class PDFFindController {
}
_extractText() {
if (this.startedTextExtraction) {
// Perform text extraction once if this method is called multiple times.
if (this.extractTextPromises.length > 0) {
return;
}
this.startedTextExtraction = true;
this.pageContents.length = 0;
let promise = Promise.resolve();
for (let i = 0, ii = this.pdfViewer.pagesCount; i < ii; i++) {