Merge pull request #11569 from Snuffleupagus/rm-most-setAttribute

Replace most remaining `Element.setAttribute("style", ...)` usage with `Element.style = ...` instead

src/display/font_loader.js

@@ -341,12 +341,11 @@ if (typeof PDFJSDev !== "undefined" && PDFJSDev.test("MOZCENTRAL")) {
       names.push(loadTestFontId);
 
       const div = document.createElement("div");
-      div.setAttribute(
-        "style",
-        "visibility: hidden;" +
-          "width: 10px; height: 10px;" +
-          "position: absolute; top: 0px; left: 0px;"
-      );
+      div.style.visibility = "hidden";
+      div.style.width = div.style.height = "10px";
+      div.style.position = "absolute";
+      div.style.top = div.style.left = "0px";
+
       for (i = 0, ii = names.length; i < ii; ++i) {
         const span = document.createElement("span");
         span.textContent = "Hi";

web/debugger.js

@@ -67,7 +67,6 @@ var FontInspector = (function FontInspectorClosure() {
     manager: null,
     init: function init(pdfjsLib) {
       var panel = this.panel;
-      panel.setAttribute("style", "padding: 5px;");
       var tmp = document.createElement("button");
       tmp.addEventListener("click", resetSelection);
       tmp.textContent = "Refresh";
@@ -178,7 +177,6 @@ var StepperManager = (function StepperManagerClosure() {
     manager: null,
     init: function init(pdfjsLib) {
       var self = this;
-      this.panel.setAttribute("style", "padding: 5px;");
       stepperControls = document.createElement("div");
       stepperChooser = document.createElement("select");
       stepperChooser.addEventListener("change", function(event) {
@@ -468,9 +466,7 @@ var Stats = (function Stats() {
     name: "Stats",
     panel: null,
     manager: null,
-    init(pdfjsLib) {
-      this.panel.setAttribute("style", "padding: 5px;");
-    },
+    init(pdfjsLib) {},
     enabled: false,
     active: false,
     // Stats specific functions.

web/pdf_outline_viewer.js

@@ -94,16 +94,11 @@ class PDFOutlineViewer {
    * @private
    */
   _setStyles(element, { bold, italic }) {
-    let styleStr = "";
     if (bold) {
-      styleStr += "font-weight: bold;";
+      element.style.fontWeight = "bold";
     }
     if (italic) {
-      styleStr += "font-style: italic;";
-    }
-
-    if (styleStr) {
-      element.setAttribute("style", styleStr);
+      element.style.fontStyle = "italic";
     }
   }
 

web/secondary_toolbar.js

@@ -340,10 +340,8 @@ class SecondaryToolbar {
     if (this.containerHeight === this.previousContainerHeight) {
       return;
     }
-    this.toolbarButtonContainer.setAttribute(
-      "style",
-      "max-height: " + (this.containerHeight - SCROLLBAR_PADDING) + "px;"
-    );
+    this.toolbarButtonContainer.style.maxHeight = `${this.containerHeight -
+      SCROLLBAR_PADDING}px`;
 
     this.previousContainerHeight = this.containerHeight;
   }

web/ui_utils.js

@@ -890,10 +890,7 @@ class ProgressBar {
     const container = viewer.parentNode;
     const scrollbarWidth = container.offsetWidth - viewer.offsetWidth;
     if (scrollbarWidth > 0) {
-      this.bar.setAttribute(
-        "style",
-        "width: calc(100% - " + scrollbarWidth + "px);"
-      );
+      this.bar.style.width = `calc(100% - ${scrollbarWidth}px)`;
     }
   }
 

web/viewer.css

@@ -1479,6 +1479,9 @@ html[dir='rtl'] #documentPropertiesOverlay .row > * {
   right: 0;
   top: 27px;
 }
+#PDFBug .panels > div {
+  padding: 5px;
+}
 #PDFBug button.active {
   font-weight: bold;
 }