Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Don't trigger worker-thread cleanup when destruction has already started

Browse Source 
Note how we're currently skipping all main-thread cleanup when document destruction has started, but for some reason we're still dispatching the "Cleanup" message.
This seems like a simple oversight, since destruction will already invoke the `BasePdfManager.cleanup` method (on the worker-thread) to fully clear-out all caches.
This commit is contained in:
Jonas Jenwald 2022-10-14 16:43:49 +02:00
parent 9f5fd075e7
commit a576ea216f
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/display/api.js
View File

@ -2997,11 +2997,11 @@ class WorkerTransport {
} }
async startCleanup(keepLoadedFonts = false) { async startCleanup(keepLoadedFonts = false) {
await this.messageHandler.sendWithPromise("Cleanup", null);
if (this.destroyed) { if (this.destroyed) {
return; // No need to manually clean-up when destruction has started. return; // No need to manually clean-up when destruction has started.
} }
await this.messageHandler.sendWithPromise("Cleanup", null);
for (const page of this.#pageCache.values()) { for (const page of this.#pageCache.values()) {
const cleanupSuccessful = page.cleanup(); const cleanupSuccessful = page.cleanup();