Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #8138 from Snuffleupagus/bug-1345253

Browse Source 
Get rid of `element.removeChild(element.firstChild)` usage (bug 1345253)
This commit is contained in:
Tim van der Meij 2017-03-08 22:29:53 +01:00 committed by GitHub
commit a544a3b4a4
2 changed files with 7 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
web/pdf_attachment_viewer.js
View File

@ -61,10 +61,8 @@ var PDFAttachmentViewer = (function PDFAttachmentViewerClosure() {
reset: function PDFAttachmentViewer_reset(keepRenderedCapability) { reset: function PDFAttachmentViewer_reset(keepRenderedCapability) {
this.attachments = null; this.attachments = null;
var container = this.container; // Remove the attachments from the DOM.
while (container.firstChild) { this.container.textContent = '';
container.removeChild(container.firstChild);
}
if (!keepRenderedCapability) { if (!keepRenderedCapability) {
// NOTE: The *only* situation in which the `_renderedCapability` should // NOTE: The *only* situation in which the `_renderedCapability` should

9
web/pdf_outline_viewer.js
View File

@ -63,10 +63,11 @@ var PDFOutlineViewer = (function PDFOutlineViewerClosure() {
this.outline = null; this.outline = null;
this.lastToggleIsShow = true; this.lastToggleIsShow = true;
var container = this.container; // Remove the outline from the DOM.
while (container.firstChild) { this.container.textContent = '';
container.removeChild(container.firstChild); // Ensure that the left (right in RTL locales) margin is always reset,
} // to prevent incorrect outline alignment if a new document is opened.
this.container.classList.remove('outlineWithDeepNesting');
}, },
/** /**