Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use the native URL.createObjectURL method in web/debugger.js

Browse Source 
There's no particular reason for using the PDF.js helper function `createObjectURL`[1] in the debugger, instead of the native `URL.createObjectURL` directly, for a couple of reasons:
 - The relevant code-path only applies to fonts loaded with the Font Loading API, and this isn't supported in IE anyway.
 - The debugger can, since quite some time, not even be loaded in IE any more.
 - General support for IE is now limited, and there's no guaratee that everything actually works.

---
[1] It provides a fallback for browsers with broken `Blob` support, which as usual means Internet Explorer :-P
This commit is contained in:
Jonas Jenwald 2020-01-28 21:00:33 +01:00
parent 474fe1757e
commit a12f78154c
2 changed files with 5 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
web/app.js
View File

@ -38,7 +38,6 @@ import {
import { AppOptions, OptionKind } from "./app_options.js"; import { AppOptions, OptionKind } from "./app_options.js";
import { import {
build, build,
createObjectURL,
getDocument, getDocument,
getFilenameFromUrl, getFilenameFromUrl,
GlobalWorkerOptions, GlobalWorkerOptions,
@ -1784,13 +1783,7 @@ function loadAndEnablePDFBug(enabledTabs) {
const appConfig = PDFViewerApplication.appConfig; const appConfig = PDFViewerApplication.appConfig;
return loadScript(appConfig.debuggerScriptPath).then(function() { return loadScript(appConfig.debuggerScriptPath).then(function() {
PDFBug.enable(enabledTabs); PDFBug.enable(enabledTabs);
PDFBug.init( PDFBug.init({ OPS }, appConfig.mainContainer);
{
OPS,
createObjectURL,
},
appConfig.mainContainer
);
}); });
} }

8
web/debugger.js
View File

@ -17,7 +17,7 @@
"use strict"; "use strict";
var FontInspector = (function FontInspectorClosure() { var FontInspector = (function FontInspectorClosure() {
var fonts, createObjectURL; var fonts;
var active = false; var active = false;
var fontAttribute = "data-font-name"; var fontAttribute = "data-font-name";
function removeSelection() { function removeSelection() {
@ -75,8 +75,6 @@ var FontInspector = (function FontInspectorClosure() {
fonts = document.createElement("div"); fonts = document.createElement("div");
panel.appendChild(fonts); panel.appendChild(fonts);
createObjectURL = pdfjsLib.createObjectURL;
}, },
cleanup: function cleanup() { cleanup: function cleanup() {
fonts.textContent = ""; fonts.textContent = "";
@ -121,7 +119,9 @@ var FontInspector = (function FontInspectorClosure() {
url = /url\(['"]?([^\)"']+)/.exec(url); url = /url\(['"]?([^\)"']+)/.exec(url);
download.href = url[1]; download.href = url[1];
} else if (fontObj.data) { } else if (fontObj.data) {
download.href = createObjectURL(fontObj.data, fontObj.mimeType); download.href = URL.createObjectURL(
new Blob([fontObj.data], { type: fontObj.mimeType })
);
} }
download.textContent = "Download"; download.textContent = "Download";
var logIt = document.createElement("a"); var logIt = document.createElement("a");