Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Move validation of chromium/preferences_schema.json to its own gulp task

Browse Source 
With the way that the `default_preferences.json` file is now generated at build time, the `gulp lint` task is now noticeably slower than before. This slowdown has been, and still is, somewhat annoying during the deployment of new ESLint rules.

Hence this patch, which moves the `chromium/preferences_schema.json` validation from `gulp lint` and into a new `gulp lint-chromium` task instead. *Obviously* this new task is run as part of the `gulp npm-test` task, and thus through `npm test` on Node.js/Travis, such that it's still being tested as before.
This commit is contained in:
Jonas Jenwald 2020-02-16 10:42:07 +01:00
parent 4092aa9fbd
commit 9fd2402321
1 changed files with 39 additions and 34 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

73
gulpfile.js
View File

@ -1389,43 +1389,45 @@ gulp.task(
})
);
gulp.task("lint", function(done) {
console.log();
console.log("### Linting JS files");
// Ensure that we lint the Firefox specific *.jsm files too.
var options = [
"node_modules/eslint/bin/eslint",
"--ext",
".js,.jsm",
".",
"--report-unused-disable-directives",
];
var esLintProcess = startNode(options, { stdio: "inherit" });
esLintProcess.on("close", function(code) {
if (code !== 0) {
done(new Error("ESLint failed."));
return;
}
console.log("files checked, no errors found");
done();
});
});
gulp.task(
"lint",
"lint-chromium",
gulp.series("default_preferences", function(done) {
console.log();
console.log("### Linting JS files");
console.log("### Checking supplemental Chromium files");
// Ensure that we lint the Firefox specific *.jsm files too.
var options = [
"node_modules/eslint/bin/eslint",
"--ext",
".js,.jsm",
".",
"--report-unused-disable-directives",
];
var esLintProcess = startNode(options, { stdio: "inherit" });
esLintProcess.on("close", function(code) {
if (code !== 0) {
done(new Error("ESLint failed."));
return;
}
console.log();
console.log("### Checking supplemental files");
if (
!checkChromePreferencesFile(
"extensions/chromium/preferences_schema.json",
"build/default_preferences.json"
)
) {
done(new Error("chromium/preferences_schema is not in sync."));
return;
}
console.log("files checked, no errors found");
done();
});
if (
!checkChromePreferencesFile(
"extensions/chromium/preferences_schema.json",
"build/default_preferences.json"
)
) {
done(new Error("chromium/preferences_schema is not in sync."));
return;
}
done();
})
);
@ -1838,5 +1840,8 @@ gulp.task("externaltest", function(done) {
gulp.task(
"npm-test",
gulp.series(gulp.parallel("lint", "externaltest"), "unittestcli")
gulp.series(
gulp.parallel("lint", "externaltest", "unittestcli"),
"lint-chromium"
)
);