Addressing reviewer comments

This commit is contained in:
Artur Adib 2012-02-16 12:02:18 -05:00
parent db5f43be46
commit 9cf9c36227

View File

@ -112,7 +112,7 @@ var Page = (function PageClosure() {
height: this.height height: this.height
}; };
if (!isArray(cropBox) || cropBox.length !== 4) if (!isArray(cropBox) || cropBox.length !== 4)
return shadow(this, 'cropBox', view); return shadow(this, 'view', view);
var mediaBox = this.mediaBox; var mediaBox = this.mediaBox;
var offsetX = mediaBox[0], offsetY = mediaBox[1]; var offsetX = mediaBox[0], offsetY = mediaBox[1];
@ -123,7 +123,7 @@ var Page = (function PageClosure() {
// effectively reduced to their intersection with the media box." // effectively reduced to their intersection with the media box."
cropBox = Util.intersect(cropBox, mediaBox); cropBox = Util.intersect(cropBox, mediaBox);
if (!cropBox) if (!cropBox)
return shadow(this, 'cropBox', view); return shadow(this, 'view', view);
var tl = this.rotatePoint(cropBox[0] - offsetX, cropBox[1] - offsetY); var tl = this.rotatePoint(cropBox[0] - offsetX, cropBox[1] - offsetY);
var br = this.rotatePoint(cropBox[2] - offsetX, cropBox[3] - offsetY); var br = this.rotatePoint(cropBox[2] - offsetX, cropBox[3] - offsetY);
@ -132,7 +132,7 @@ var Page = (function PageClosure() {
view.width = Math.abs(tl.x - br.x); view.width = Math.abs(tl.x - br.x);
view.height = Math.abs(tl.y - br.y); view.height = Math.abs(tl.y - br.y);
return shadow(this, 'cropBox', view); return shadow(this, 'view', view);
}, },
get annotations() { get annotations() {
return shadow(this, 'annotations', this.inheritPageProp('Annots')); return shadow(this, 'annotations', this.inheritPageProp('Annots'));