Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Ensure that we don't modify the Dict data when the Differences array of a font contains indirect objects

Browse Source 
This patch fixes an issue that I inadvertently introduced in PR 5815, where we accidentally modify the `Differences` array in the encoding dictionary for indirect objects.

Instead of this change, we could also have used the now existing `Dict_getArray`. However in this case I don't think that would have been a good idea, since it would mean iterating through the array *twice*.
This commit is contained in:
Jonas Jenwald 2016-01-29 18:22:25 +01:00
parent 5d797e1a85
commit 992472fd38
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/core/evaluator.js
View File

@ -1566,14 +1566,11 @@ var PartialEvaluator = (function PartialEvaluatorClosure() {
var diffEncoding = encoding.get('Differences'); var diffEncoding = encoding.get('Differences');
var index = 0; var index = 0;
for (var j = 0, jj = diffEncoding.length; j < jj; j++) { for (var j = 0, jj = diffEncoding.length; j < jj; j++) {
var data = diffEncoding[j]; var data = xref.fetchIfRef(diffEncoding[j]);
if (isNum(data)) { if (isNum(data)) {
index = data; index = data;
} else if (isName(data)) { } else if (isName(data)) {
differences[index++] = data.name; differences[index++] = data.name;
} else if (isRef(data)) {
diffEncoding[j--] = xref.fetch(data);
continue;
} else { } else {
error('Invalid entry in \'Differences\' array: ' + data); error('Invalid entry in \'Differences\' array: ' + data);
} }