[Editor] Extract all the lines when adding a FreeText annotation
Fixes #17079.
This commit is contained in:
parent
0d011472a4
commit
9765d57a26
@ -386,13 +386,14 @@ class FreeTextEditor extends AnnotationEditor {
|
|||||||
* @returns {string}
|
* @returns {string}
|
||||||
*/
|
*/
|
||||||
#extractText() {
|
#extractText() {
|
||||||
const divs = this.editorDiv.getElementsByTagName("div");
|
// We don't use innerText because there are some bugs with line breaks.
|
||||||
if (divs.length === 0) {
|
|
||||||
return this.editorDiv.innerText;
|
|
||||||
}
|
|
||||||
const buffer = [];
|
const buffer = [];
|
||||||
for (const div of divs) {
|
this.editorDiv.normalize();
|
||||||
buffer.push(div.innerText.replace(/\r\n?|\n/, ""));
|
const EOL_PATTERN = /\r\n?|\n/g;
|
||||||
|
for (const child of this.editorDiv.childNodes) {
|
||||||
|
const content =
|
||||||
|
child.nodeType === Node.TEXT_NODE ? child.nodeValue : child.innerText;
|
||||||
|
buffer.push(content.replaceAll(EOL_PATTERN, ""));
|
||||||
}
|
}
|
||||||
return buffer.join("\n");
|
return buffer.join("\n");
|
||||||
}
|
}
|
||||||
|
@ -3246,4 +3246,50 @@ describe("FreeText Editor", () => {
|
|||||||
);
|
);
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
|
describe("Freetext with several lines", () => {
|
||||||
|
let pages;
|
||||||
|
|
||||||
|
beforeAll(async () => {
|
||||||
|
pages = await loadAndWait("empty.pdf", ".annotationEditorLayer");
|
||||||
|
});
|
||||||
|
|
||||||
|
afterAll(async () => {
|
||||||
|
await closePages(pages);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("must check that all lines are correctly exported", async () => {
|
||||||
|
await Promise.all(
|
||||||
|
pages.map(async ([browserName, page]) => {
|
||||||
|
await switchToFreeText(page);
|
||||||
|
|
||||||
|
const rect = await page.$eval(".annotationEditorLayer", el => {
|
||||||
|
// With Chrome something is wrong when serializing a DomRect,
|
||||||
|
// hence we extract the values and just return them.
|
||||||
|
const { x, y } = el.getBoundingClientRect();
|
||||||
|
return { x, y };
|
||||||
|
});
|
||||||
|
|
||||||
|
const data = "Hello\nPDF.js\nWorld\n!!";
|
||||||
|
await page.mouse.click(rect.x + 100, rect.y + 100);
|
||||||
|
await page.waitForSelector(getEditorSelector(0), {
|
||||||
|
visible: true,
|
||||||
|
});
|
||||||
|
await page.type(`${getEditorSelector(0)} .internal`, data);
|
||||||
|
|
||||||
|
// Commit.
|
||||||
|
await page.keyboard.press("Escape");
|
||||||
|
await page.waitForSelector(
|
||||||
|
`${getEditorSelector(0)} .overlay.enabled`
|
||||||
|
);
|
||||||
|
|
||||||
|
await waitForSerialized(page, 1);
|
||||||
|
const serialized = (await getSerialized(page))[0];
|
||||||
|
expect(serialized.value)
|
||||||
|
.withContext(`In ${browserName}`)
|
||||||
|
.toEqual(data);
|
||||||
|
})
|
||||||
|
);
|
||||||
|
});
|
||||||
|
});
|
||||||
});
|
});
|
||||||
|
Loading…
x
Reference in New Issue
Block a user