From 96dbe38544f0651ff492213e0b27b57cb901de1a Mon Sep 17 00:00:00 2001 From: Jonas Jenwald Date: Wed, 11 Aug 2021 17:35:56 +0200 Subject: [PATCH] Update some deprecated ESLint rules Please see https://eslint.org/docs/rules/#deprecated where the following rules apply to the PDF.js project: - [`no-buffer-constructor`](https://eslint.org/docs/rules/no-buffer-constructor), which we can replace with the `unicorn/no-new-buffer` rule; see https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/no-new-buffer.md - [`no-catch-shadow`](https://eslint.org/docs/rules/no-catch-shadow), which was replaced by the `no-shadow` rule (that we're already using). --- .eslintrc | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/.eslintrc b/.eslintrc index 29c8a7204..fe0717c23 100644 --- a/.eslintrc +++ b/.eslintrc @@ -46,6 +46,7 @@ }], "unicorn/no-abusive-eslint-disable": "error", "unicorn/no-array-push-push": "error", + "unicorn/no-new-buffer": "error", "unicorn/no-instanceof-array": "error", "unicorn/no-useless-spread": "error", "unicorn/prefer-string-starts-ends-with": "error", @@ -136,7 +137,6 @@ "strict": ["off", "global"], // Variables - "no-catch-shadow": "error", "no-delete-var": "error", "no-label-var": "error", "no-shadow": "error", @@ -153,9 +153,6 @@ "variables": false, }], - // Node.js and CommonJS - "no-buffer-constructor": "error", - // Stylistic Issues "lines-between-class-members": ["error", "always"], "max-len": ["error", {