Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Avoid doing unnecessary work in AnnotationLayerBuilder.render, such as cloning a PageViewport, when no annotations exist for a page

Browse Source
This commit is contained in:
Jonas Jenwald 2020-07-31 16:42:49 +02:00
parent 346afd1e1c
commit 95bfc43a3b
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
web/annotation_layer_builder.js
View File

@ -66,6 +66,9 @@ class AnnotationLayerBuilder {
if (this._cancelled) { if (this._cancelled) {
return; return;
} }
if (annotations.length === 0) {
return;
}
const parameters = { const parameters = {
viewport: viewport.clone({ dontFlip: true }), viewport: viewport.clone({ dontFlip: true }),
@ -86,9 +89,6 @@ class AnnotationLayerBuilder {
} else { } else {
// Create an annotation layer div and render the annotations // Create an annotation layer div and render the annotations
// if there is at least one annotation. // if there is at least one annotation.
if (annotations.length === 0) {
return;
}
this.div = document.createElement("div"); this.div = document.createElement("div");
this.div.className = "annotationLayer"; this.div.className = "annotationLayer";
this.pageDiv.appendChild(this.div); this.pageDiv.appendChild(this.div);