Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use Promise.prototype.finally in the PDFRenderingQueue.renderView method

Browse Source 
Since [`finally`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise/finally) is now supported through `src/shared/compatibility.js`, the temporary variable is no longer necessary.

Also, this patch fixes the inconsistent return type of `PDFRenderingQueue.getHighestPriority` when no pages/thumbnails are visible.
This commit is contained in:
Jonas Jenwald 2019-02-25 12:20:51 +01:00
parent de56518799
commit 954bebb3c3
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
web/pdf_rendering_queue.js
View File

@ -107,7 +107,7 @@ class PDFRenderingQueue {
let numVisible = visibleViews.length;
if (numVisible === 0) {
return false;
return null;
}
for (let i = 0; i < numVisible; ++i) {
let view = visibleViews[i].view;
@ -162,10 +162,9 @@ class PDFRenderingQueue {
break;
case RenderingStates.INITIAL:
this.highestPriorityPage = view.renderingId;
let continueRendering = () => {
view.draw().finally(() => {
this.renderHighestPriority();
};
view.draw().then(continueRendering, continueRendering);
});
break;
}
return true;