Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add a unit-test that attempts to fetch a non-existent named destination

Browse Source 
Doing this helped uncover an issue with the `getDestination` implementation.
Currently if a named destination doesn't exist, the method (in `obj.js`) may return `undefined` which leads to the promise being stuck in a pending state.
*Note:* returning `null` for this case is consistent with other methods, e.g. `getOutline` and `getAttachments`.
This commit is contained in:
Jonas Jenwald 2015-07-07 21:48:57 +02:00
parent eb2ad11571
commit 940bedf75f
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/core/obj.js
View File

@ -485,7 +485,7 @@ var Catalog = (function CatalogClosure() {
} }
var xref = this.xref; var xref = this.xref;
var dest, nameTreeRef, nameDictionaryRef; var dest = null, nameTreeRef, nameDictionaryRef;
var obj = this.catDict.get('Names'); var obj = this.catDict.get('Names');
if (obj && obj.has('Dests')) { if (obj && obj.has('Dests')) {
nameTreeRef = obj.getRaw('Dests'); nameTreeRef = obj.getRaw('Dests');

6
test/unit/api_spec.js
View File

@ -129,6 +129,12 @@ describe('api', function() {
0, 841.89, null]); 0, 841.89, null]);
}); });
}); });
it('gets a non-existent destination', function() {
var promise = doc.getDestination('non-existent-named-destination');
waitsForPromiseResolved(promise, function(data) {
expect(data).toEqual(null);
});
});
it('gets attachments', function() { it('gets attachments', function() {
var promise = doc.getAttachments(); var promise = doc.getAttachments();
waitsForPromiseResolved(promise, function (data) { waitsForPromiseResolved(promise, function (data) {