Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Convert some properties, on PDFThumbnailView-instances, to local variables

Browse Source 
These properties are always updated/used together, and there's no other methods which depend on just one of them, hence they're changed into local variables instead.
Looking through the history of this code, it seems they were converted *from* local variables and to properties all the way back in PR 2914; however as far as I can tell from that diff it doesn't seem to have been necessary even back then!?
This commit is contained in:
Jonas Jenwald 2021-04-08 12:21:52 +02:00
parent 6429ccc002
commit 8ea83f7030
1 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
web/pdf_thumbnail_view.js
View File

@ -122,13 +122,13 @@ class PDFThumbnailView {
}; };
this.disableCanvasToImageConversion = disableCanvasToImageConversion; this.disableCanvasToImageConversion = disableCanvasToImageConversion;
this.pageWidth = this.viewport.width; const pageWidth = this.viewport.width,
this.pageHeight = this.viewport.height; pageHeight = this.viewport.height,
this.pageRatio = this.pageWidth / this.pageHeight; pageRatio = pageWidth / pageHeight;
this.canvasWidth = THUMBNAIL_WIDTH; this.canvasWidth = THUMBNAIL_WIDTH;
this.canvasHeight = (this.canvasWidth / this.pageRatio) | 0; this.canvasHeight = (this.canvasWidth / pageRatio) | 0;
this.scale = this.canvasWidth / this.pageWidth; this.scale = this.canvasWidth / pageWidth;
this.l10n = l10n; this.l10n = l10n;
@ -172,12 +172,12 @@ class PDFThumbnailView {
this.cancelRendering(); this.cancelRendering();
this.renderingState = RenderingStates.INITIAL; this.renderingState = RenderingStates.INITIAL;
this.pageWidth = this.viewport.width; const pageWidth = this.viewport.width,
this.pageHeight = this.viewport.height; pageHeight = this.viewport.height,
this.pageRatio = this.pageWidth / this.pageHeight; pageRatio = pageWidth / pageHeight;
this.canvasHeight = (this.canvasWidth / this.pageRatio) | 0; this.canvasHeight = (this.canvasWidth / pageRatio) | 0;
this.scale = this.canvasWidth / this.pageWidth; this.scale = this.canvasWidth / pageWidth;
this.div.removeAttribute("data-loaded"); this.div.removeAttribute("data-loaded");
const ring = this.ring; const ring = this.ring;