Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Move _updateScrollModeClasses from BaseViewer to PDFViewer

Browse Source 
Given that this method is a no-op in `PDFSinglePageViewer`, similar to `_regroupSpreads`, let's improve the general code structure by simply moving the method.
This commit is contained in:
Jonas Jenwald 2018-06-21 20:30:58 +02:00
parent da52dff04b
commit 8bd1244298
2 changed files with 19 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
web/base_viewer.js
View File

@ -1043,18 +1043,7 @@ class BaseViewer {
}
_updateScrollModeClasses() {
const { scrollMode, viewer, } = this;
if (scrollMode === ScrollMode.HORIZONTAL) {
viewer.classList.add('scrollHorizontal');
} else {
viewer.classList.remove('scrollHorizontal');
}
if (scrollMode === ScrollMode.WRAPPED) {
viewer.classList.add('scrollWrapped');
} else {
viewer.classList.remove('scrollWrapped');
}
// No-op in the base class.
}
setSpreadMode(mode) {
@ -1070,7 +1059,9 @@ class BaseViewer {
this._regroupSpreads();
}
_regroupSpreads() {}
_regroupSpreads() {
// No-op in the base class.
}
}
export {

15
web/pdf_viewer.js
View File

@ -87,6 +87,21 @@ class PDFViewer extends BaseViewer {
});
}
_updateScrollModeClasses() {
const { scrollMode, viewer, } = this;
if (scrollMode === ScrollMode.HORIZONTAL) {
viewer.classList.add('scrollHorizontal');
} else {
viewer.classList.remove('scrollHorizontal');
}
if (scrollMode === ScrollMode.WRAPPED) {
viewer.classList.add('scrollWrapped');
} else {
viewer.classList.remove('scrollWrapped');
}
}
_regroupSpreads() {
const viewer = this.viewer, pages = this._pages;
// Temporarily remove all the pages from the DOM.