Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[Firefox viewer] Stop using FirefoxCom.requestAsync in the DownloadManager

Browse Source 
After the changes in https://bugzilla.mozilla.org/show_bug.cgi?id=1757771, that simplified the MOZCENTRAL downloading code, the `ChromeActions.download`-method will no longer invoke the `sendResponse`-callback.
Hence it should no longer be necessary for the `DownloadManager`, in the MOZCENTRAL viewer, to use `FirefoxCom.requestAsync` since no response is ever provided.[1] For the allocated BlobURLs, they should (hopefully) be released when navigating away from the viewer.

---
[1] Note that that was *already* the case, for one of the previous code-paths in the `ChromeActions.download`-method.
This commit is contained in:
Jonas Jenwald 2022-05-10 14:15:57 +02:00
parent 4f1cd6a9c2
commit 8a349801dc
1 changed files with 2 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
web/firefoxcom.js
View File

@ -116,13 +116,11 @@ class DownloadManager {
new Blob([data], { type: contentType })
);
FirefoxCom.requestAsync("download", {
FirefoxCom.request("download", {
blobUrl,
originalUrl: blobUrl,
filename,
isAttachment: true,
}).then(error => {
URL.revokeObjectURL(blobUrl);
});
}
@ -161,17 +159,10 @@ class DownloadManager {
download(blob, url, filename) {
const blobUrl = URL.createObjectURL(blob);
FirefoxCom.requestAsync("download", {
FirefoxCom.request("download", {
blobUrl,
originalUrl: url,
filename,
}).then(error => {
if (error) {
// If downloading failed in `PdfStreamConverter.jsm` it's very unlikely
// that attempting to fallback and re-download would be helpful here.
console.error("`ChromeActions.download` failed.");
}
URL.revokeObjectURL(blobUrl);
});
}
}