From 8a22a43cf3bd5981c6382e735582e11fb3ec36c2 Mon Sep 17 00:00:00 2001 From: gigaherz Date: Fri, 10 Feb 2012 17:34:38 +0100 Subject: [PATCH] No need to be paranoid, the code isn't going to contain both classes at once unless someone messes up, and then it's not my fault. --- web/viewer.js | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/web/viewer.js b/web/viewer.js index e0822990b..a108591d4 100644 --- a/web/viewer.js +++ b/web/viewer.js @@ -576,18 +576,20 @@ var PDFView = { var sidebar = document.getElementById('sidebar'); var pinIcon = document.getElementById('pinIcon'); - sidebar.classList.remove('released'); - pinIcon.classList.remove('released'); - sidebar.classList.remove('pinned'); - pinIcon.classList.remove('pinned'); + var oldClass = 'released'; + var newClass = 'pinned'; - this.pinState = !this.pinState; - - var newClass = this.pinState ? 'pinned' : 'released'; + if (this.pinState) { + oldClass = 'pinned'; + newClass = 'released'; + } + sidebar.classList.remove(oldClass); + pinIcon.classList.remove(oldClass); sidebar.classList.add(newClass); pinIcon.classList.add(newClass); + this.pinState = !this.pinState; }, getVisiblePages: function pdfViewGetVisiblePages() {