Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Re-use, rather than re-creating, some Arrays when resetting them in src/display/api.js

Browse Source 
Calling `someArray = []` will create a new Array, which seems completely unnecessary when it's sufficient to just call `someArray.length = 0` to achieve the same effect.

Even though I cannot imagine these particular cases having any noticeable performance impact, similar changes were made in `core/` code years ago since it's apparently more efficient memory wise.
This commit is contained in:
Jonas Jenwald 2019-05-30 16:25:48 +02:00
parent d0892e46e2
commit 8857a81c8d
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/display/api.js
View File

@ -1377,7 +1377,7 @@ class LoopbackPort {
} }
terminate() { terminate() {
this._listeners = []; this._listeners.length = 0;
} }
} }
@ -1760,8 +1760,8 @@ class WorkerTransport {
waitOn.push(page._destroy()); waitOn.push(page._destroy());
} }
}); });
this.pageCache = []; this.pageCache.length = 0;
this.pagePromises = []; this.pagePromises.length = 0;
// We also need to wait for the worker to finish its long running tasks. // We also need to wait for the worker to finish its long running tasks.
const terminated = this.messageHandler.sendWithPromise('Terminate', null); const terminated = this.messageHandler.sendWithPromise('Terminate', null);
waitOn.push(terminated); waitOn.push(terminated);