Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Lazily initialize, and cache, the regular expression used in CFFCompiler.encodeFloat

Browse Source 
There's no particular reason for re-creating the regular expression over and over for every `encodeFloat` invocation, as far as I can tell.
This commit is contained in:
Jonas Jenwald 2020-06-15 13:24:20 +02:00
parent 517d92a121
commit 87b089ba42
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/core/cff_parser.js
View File

@ -1366,6 +1366,8 @@ var CFFOffsetTracker = (function CFFOffsetTrackerClosure() {
// Takes a CFF and converts it to the binary representation. // Takes a CFF and converts it to the binary representation.
var CFFCompiler = (function CFFCompilerClosure() { var CFFCompiler = (function CFFCompilerClosure() {
let EncodeFloatRegExp = null; // Lazily initialized by `encodeFloat`.
// eslint-disable-next-line no-shadow // eslint-disable-next-line no-shadow
function CFFCompiler(cff) { function CFFCompiler(cff) {
this.cff = cff; this.cff = cff;
@ -1491,8 +1493,11 @@ var CFFCompiler = (function CFFCompilerClosure() {
encodeFloat: function CFFCompiler_encodeFloat(num) { encodeFloat: function CFFCompiler_encodeFloat(num) {
var value = num.toString(); var value = num.toString();
// rounding inaccurate doubles if (!EncodeFloatRegExp) {
var m = /\.(\d*?)(?:9{5,20}|0{5,20})\d{0,2}(?:e(.+)|$)/.exec(value); EncodeFloatRegExp = /\.(\d*?)(?:9{5,20}|0{5,20})\d{0,2}(?:e(.+)|$)/;
}
// Rounding inaccurate doubles.
var m = EncodeFloatRegExp.exec(value);
if (m) { if (m) {
var epsilon = parseFloat("1e" + ((m[2] ? +m[2] : 0) + m[1].length)); var epsilon = parseFloat("1e" + ((m[2] ? +m[2] : 0) + m[1].length));
value = (Math.round(num * epsilon) / epsilon).toString(); value = (Math.round(num * epsilon) / epsilon).toString();