From 867150e4f037255097f33c657835f5a815d5bcb8 Mon Sep 17 00:00:00 2001
From: Rob Wu <rob@robwu.nl>
Date: Sun, 1 Aug 2021 18:51:02 +0200
Subject: [PATCH] [CRX] Add option to customize Theme in options UI

The `viewerCssTheme` option was not rendered because its entry in
`preferences_schema.json` did not have a `title`.

The order of keys in `preferences_schema.json` determines the order of the
rendered preferences in the options UI. Since `viewerCssTheme` affects the UI
very significantly, I have moved the option to the top.
---
 extensions/chromium/options/options.html    | 13 +++++++++++++
 extensions/chromium/preferences_schema.json | 20 +++++++++++---------
 2 files changed, 24 insertions(+), 9 deletions(-)

diff --git a/extensions/chromium/options/options.html b/extensions/chromium/options/options.html
index 57ddae7b1..ef4bec4d0 100644
--- a/extensions/chromium/options/options.html
+++ b/extensions/chromium/options/options.html
@@ -43,6 +43,19 @@ body {
 </div>
 </template>
 
+<template id="viewerCssTheme-template">
+<div class="settings-row">
+  <label>
+    <span></span>
+    <select>
+      <option value="0">Use system theme</option>
+      <option value="1">Light theme</option>
+      <option value="2">Dark theme</option>
+    </select>
+  </label>
+</div>
+</template>
+
 <template id="viewOnLoad-template">
 <div class="settings-row">
   <label>
diff --git a/extensions/chromium/preferences_schema.json b/extensions/chromium/preferences_schema.json
index d6eb5d89b..e3a3b8d38 100644
--- a/extensions/chromium/preferences_schema.json
+++ b/extensions/chromium/preferences_schema.json
@@ -1,6 +1,17 @@
 {
   "type": "object",
   "properties": {
+    "viewerCssTheme": {
+      "title": "Theme",
+      "description": "The theme to use.\n0 = Use system theme.\n1 = Light theme.\n2 = Dark theme.",
+      "type": "integer",
+      "enum": [
+        0,
+        1,
+        2
+      ],
+      "default": 0
+    },
     "showPreviousViewOnLoad": {
       "description": "DEPRECATED. Set viewOnLoad to 1 to disable showing the last page/position on load.",
       "type": "boolean",
@@ -188,15 +199,6 @@
         2
       ],
       "default": -1
-    },
-    "viewerCssTheme": {
-      "type": "integer",
-      "enum": [
-        0,
-        1,
-        2
-      ],
-      "default": 0
     }
   }
 }