Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #11427 from wojtekmaj/view-history-const

Browse Source 
Use const in view_history.js
This commit is contained in:
Tim van der Meij 2019-12-23 22:33:11 +01:00 committed by GitHub
commit 8638b0c88a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
web/view_history.js
View File

@ -12,6 +12,7 @@
* See the License for the specific language governing permissions and * See the License for the specific language governing permissions and
* limitations under the License. * limitations under the License.
*/ */
/* eslint no-var: error, prefer-const: error */
const DEFAULT_VIEW_HISTORY_CACHE_SIZE = 20; const DEFAULT_VIEW_HISTORY_CACHE_SIZE = 20;
@ -30,7 +31,7 @@ class ViewHistory {
this.cacheSize = cacheSize; this.cacheSize = cacheSize;
this._initializedPromise = this._readFromStorage().then((databaseStr) => { this._initializedPromise = this._readFromStorage().then((databaseStr) => {
let database = JSON.parse(databaseStr || '{}'); const database = JSON.parse(databaseStr || '{}');
if (!('files' in database)) { if (!('files' in database)) {
database.files = []; database.files = [];
} else { } else {
@ -40,7 +41,7 @@ class ViewHistory {
} }
let index = -1; let index = -1;
for (let i = 0, length = database.files.length; i < length; i++) { for (let i = 0, length = database.files.length; i < length; i++) {
let branch = database.files[i]; const branch = database.files[i];
if (branch.fingerprint === this.fingerprint) { if (branch.fingerprint === this.fingerprint) {
index = i; index = i;
break; break;
@ -55,7 +56,7 @@ class ViewHistory {
} }
async _writeToStorage() { async _writeToStorage() {
let databaseStr = JSON.stringify(this.database); const databaseStr = JSON.stringify(this.database);
if (typeof PDFJSDev !== 'undefined' && if (typeof PDFJSDev !== 'undefined' &&
PDFJSDev.test('FIREFOX || MOZCENTRAL')) { PDFJSDev.test('FIREFOX || MOZCENTRAL')) {
@ -81,7 +82,7 @@ class ViewHistory {
async setMultiple(properties) { async setMultiple(properties) {
await this._initializedPromise; await this._initializedPromise;
for (let name in properties) { for (const name in properties) {
this.file[name] = properties[name]; this.file[name] = properties[name];
} }
return this._writeToStorage(); return this._writeToStorage();
@ -89,16 +90,16 @@ class ViewHistory {
async get(name, defaultValue) { async get(name, defaultValue) {
await this._initializedPromise; await this._initializedPromise;
let val = this.file[name]; const val = this.file[name];
return val !== undefined ? val : defaultValue; return val !== undefined ? val : defaultValue;
} }
async getMultiple(properties) { async getMultiple(properties) {
await this._initializedPromise; await this._initializedPromise;
let values = Object.create(null); const values = Object.create(null);
for (let name in properties) { for (const name in properties) {
let val = this.file[name]; const val = this.file[name];
values[name] = val !== undefined ? val : properties[name]; values[name] = val !== undefined ? val : properties[name];
} }
return values; return values;