Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Allow BaseLocalCache to, optionally, only allocate storage for caching of references (PR 12034 follow-up)

Browse Source 
*Yet another instalment in the never-ending series of things that you think of __after__ a patch has landed.*

Since `Function`s are only cached by reference, we thus don't need to allocate storage for names in `LocalFunctionCache` instances. Obviously the effect of these changes are *really tiny*, but it seems reasonable in principle to avoid allocating data structures that are guaranteed to be unused.
This commit is contained in:
Jonas Jenwald 2020-07-04 14:52:10 +02:00
parent 29548ad498
commit 85ced3fbfd
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/core/image_utils.js
View File

@ -18,12 +18,14 @@ import { assert, info, shadow, unreachable } from "../shared/util.js";
import { RefSetCache } from "./primitives.js"; import { RefSetCache } from "./primitives.js";
class BaseLocalCache { class BaseLocalCache {
constructor() { constructor(options) {
if (this.constructor === BaseLocalCache) { if (this.constructor === BaseLocalCache) {
unreachable("Cannot initialize BaseLocalCache."); unreachable("Cannot initialize BaseLocalCache.");
} }
this._nameRefMap = new Map(); if (!options || !options.onlyRefs) {
this._imageMap = new Map(); this._nameRefMap = new Map();
this._imageMap = new Map();
}
this._imageCache = new RefSetCache(); this._imageCache = new RefSetCache();
} }
@ -92,6 +94,10 @@ class LocalColorSpaceCache extends BaseLocalCache {
} }
class LocalFunctionCache extends BaseLocalCache { class LocalFunctionCache extends BaseLocalCache {
constructor(options) {
super({ onlyRefs: true });
}
getByName(name) { getByName(name) {
unreachable("Should not call `getByName` method."); unreachable("Should not call `getByName` method.");
} }