Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Optimize Ref_toString().

Browse Source 
I have a large PDF where this function is called 1.6 million times
during loading. Minimizing the string concatenations reduces the
cumulative allocations done by Firefox within this function from 113 MB
to 48 MB.
This commit is contained in:
Nicholas Nethercote 2014-07-24 06:32:10 -07:00
parent 584fef90ab
commit 856e1c600b
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/core/obj.js
View File

@ -220,7 +220,13 @@ var Ref = (function RefClosure() {
Ref.prototype = {
toString: function Ref_toString() {
return 'R' + this.num + '.' + this.gen;
// This function is hot, so we make the string as compact as possible.
// |this.gen| is almost always zero, so we treat that case specially.
var str = this.num + 'R';
if (this.gen !== 0) {
str += this.gen;
}
return str;
}
};