Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove PDFPageProxy.getJSActions caching, since it's unused, in the API

Browse Source 
Note how, in the scripting initialization in the viewer, we only ever invoke `PDFPageProxy.getJSActions` *once* per page in order to improve overall performance; see a575aa13b9/web/pdf_scripting_manager.js (L372-L375)

Hence it really shouldn't be necessary to cache its result in the API, especially when that is done *manually* rather than using something like `shadow`.
This commit is contained in:
Jonas Jenwald 2022-12-27 10:35:03 +01:00
parent a575aa13b9
commit 841abb53e6
1 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/display/api.js
View File

@ -1338,9 +1338,7 @@ class PDFPageProxy {
* {Object} with JS actions. * {Object} with JS actions.
*/ */
getJSActions() { getJSActions() {
return (this._jsActionsPromise ||= this._transport.getPageJSActions( return this._transport.getPageJSActions(this._pageIndex);
this._pageIndex
));
} }
/** /**
@ -1656,7 +1654,6 @@ class PDFPageProxy {
bitmap.close(); bitmap.close();
} }
this._bitmaps.clear(); this._bitmaps.clear();
this._jsActionsPromise = null;
this.pendingCleanup = false; this.pendingCleanup = false;
return Promise.all(waitOn); return Promise.all(waitOn);
} }
@ -1689,7 +1686,6 @@ class PDFPageProxy {
this._intentStates.clear(); this._intentStates.clear();
this.objs.clear(); this.objs.clear();
this._jsActionsPromise = null;
if (resetStats && this._stats) { if (resetStats && this._stats) {
this._stats = new StatTimer(); this._stats = new StatTimer();
} }