Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove the scale-not-initialized hack from webViewerResize (in app.js)

Browse Source 
Since we no longer, after PR 8555, allow changing the scale until the document is loaded, that hack is no longer necessary. Furthermore, no part of that event handling function needs to run unless a document is loaded.

The reason that this hack was initially added, is that previously the `ViewHistory` might be updated *before* `PDFViewerApplication.setInitialView` had run (in some cases leading to incorrect inital document scale). Since that is no longer possible, this is now dead code.
This commit is contained in:
Jonas Jenwald 2017-07-06 13:13:22 +02:00
parent 12f1b747b1
commit 8391aacb89
1 changed files with 7 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
web/app.js
View File

@ -1790,19 +1790,18 @@ function webViewerUpdateViewarea(evt) {
}
function webViewerResize() {
let currentScaleValue = PDFViewerApplication.pdfViewer.currentScaleValue;
let { pdfDocument, pdfViewer, } = PDFViewerApplication;
if (!pdfDocument) {
return;
}
let currentScaleValue = pdfViewer.currentScaleValue;
if (currentScaleValue === 'auto' ||
currentScaleValue === 'page-fit' ||
currentScaleValue === 'page-width') {
// Note: the scale is constant for 'page-actual'.
PDFViewerApplication.pdfViewer.currentScaleValue = currentScaleValue;
} else if (!currentScaleValue) {
// Normally this shouldn't happen, but if the scale wasn't initialized
// we set it to the default value in order to prevent any issues.
// (E.g. the document being rendered with the wrong scale on load.)
PDFViewerApplication.pdfViewer.currentScaleValue = DEFAULT_SCALE_VALUE;
pdfViewer.currentScaleValue = currentScaleValue;
}
PDFViewerApplication.pdfViewer.update();
pdfViewer.update();
}
function webViewerHashchange(evt) {