From 815544ab814eb1c659cab1e9cdc082ae1b6ce37e Mon Sep 17 00:00:00 2001 From: Andreas Gal Date: Wed, 15 Jun 2011 00:37:15 -0700 Subject: [PATCH] fixes suggested by @brendaneich --- pdf.js | 35 +++++++---------------------------- 1 file changed, 7 insertions(+), 28 deletions(-) diff --git a/pdf.js b/pdf.js index 6e6935f13..3468c7b88 100644 --- a/pdf.js +++ b/pdf.js @@ -590,7 +590,7 @@ function IsString(v) { } function IsNull(v) { - return v == null; + return v === null; } function IsName(v) { @@ -617,27 +617,6 @@ function IsRef(v) { return v instanceof Ref; } -function IsFunction(v) { - var fnDict; - if (typeof v != "object") - return false; - else if (IsDict(v)) - fnDict = v; - else if (IsStream(v)) - fnDict = v.dict; - else - return false; - return fnDict.has("FunctionType"); -} - -function IsFunctionDict(v) { - return IsFunction(v) && IsDict(v); -} - -function IsFunctionStream(v) { - return IsFunction(v) && IsStream(v); -} - var EOF = {}; function IsEOF(v) { @@ -841,10 +820,12 @@ var Lexer = (function() { ch = stream.getChar(); if (ch == '>') { break; - } else if (!ch) { + } + if (!ch) { warn("Unterminated hex string"); break; - } else if (specialChars[ch.charCodeAt(0)] != 1) { + } + if (specialChars[ch.charCodeAt(0)] != 1) { var x, x2; if (((x = ToHexDigit(ch)) == -1) || ((x2 = ToHexDigit(stream.getChar())) == -1)) { @@ -1722,7 +1703,7 @@ var CanvasGraphics = (function() { return arg; } - var src = "{\n"; + var src = ""; var args = []; var map = this.map; @@ -1781,9 +1762,7 @@ var CanvasGraphics = (function() { } } - src += "}"; - - var fn = new Function("objpool", src); + var fn = Function("objpool", src); return function (gfx) { fn.call(gfx, objpool); }; },