Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use the new iterator in the PDFPageViewBuffer unit-tests

Browse Source 
The previous patch introduced an iterator in the `PDFPageViewBuffer`-class, hence the test-only `_buffer`-getter is no longer necessary.
This commit is contained in:
Jonas Jenwald 2021-11-15 13:26:50 +01:00
parent e909fcdba8
commit 7d4c37e988
2 changed files with 8 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
test/unit/base_viewer_spec.js
View File

@ -40,7 +40,7 @@ describe("BaseViewer", function () {
buffer.push(view); buffer.push(view);
} }
// Ensure that the correct views are inserted. // Ensure that the correct views are inserted.
expect(buffer._buffer).toEqual([ expect([...buffer]).toEqual([
viewsMap.get(1), viewsMap.get(1),
viewsMap.get(2), viewsMap.get(2),
viewsMap.get(3), viewsMap.get(3),
@ -51,7 +51,7 @@ describe("BaseViewer", function () {
buffer.push(view); buffer.push(view);
} }
// Ensure that the correct views are evicted. // Ensure that the correct views are evicted.
expect(buffer._buffer).toEqual([ expect([...buffer]).toEqual([
viewsMap.get(3), viewsMap.get(3),
viewsMap.get(4), viewsMap.get(4),
viewsMap.get(5), viewsMap.get(5),
@ -71,7 +71,7 @@ describe("BaseViewer", function () {
// Ensure that keeping the size constant won't evict any views. // Ensure that keeping the size constant won't evict any views.
buffer.resize(5); buffer.resize(5);
expect(buffer._buffer).toEqual([ expect([...buffer]).toEqual([
viewsMap.get(1), viewsMap.get(1),
viewsMap.get(2), viewsMap.get(2),
viewsMap.get(3), viewsMap.get(3),
@ -82,7 +82,7 @@ describe("BaseViewer", function () {
// Ensure that increasing the size won't evict any views. // Ensure that increasing the size won't evict any views.
buffer.resize(10); buffer.resize(10);
expect(buffer._buffer).toEqual([ expect([...buffer]).toEqual([
viewsMap.get(1), viewsMap.get(1),
viewsMap.get(2), viewsMap.get(2),
viewsMap.get(3), viewsMap.get(3),
@ -93,7 +93,7 @@ describe("BaseViewer", function () {
// Ensure that decreasing the size will evict the correct views. // Ensure that decreasing the size will evict the correct views.
buffer.resize(3); buffer.resize(3);
expect(buffer._buffer).toEqual([ expect([...buffer]).toEqual([
viewsMap.get(3), viewsMap.get(3),
viewsMap.get(4), viewsMap.get(4),
viewsMap.get(5), viewsMap.get(5),
@ -114,7 +114,7 @@ describe("BaseViewer", function () {
// while re-ordering them correctly. // while re-ordering them correctly.
buffer.resize(5, new Set([1, 2])); buffer.resize(5, new Set([1, 2]));
expect(buffer._buffer).toEqual([ expect([...buffer]).toEqual([
viewsMap.get(3), viewsMap.get(3),
viewsMap.get(4), viewsMap.get(4),
viewsMap.get(5), viewsMap.get(5),
@ -126,7 +126,7 @@ describe("BaseViewer", function () {
// while re-ordering them correctly. // while re-ordering them correctly.
buffer.resize(10, new Set([3, 4, 5])); buffer.resize(10, new Set([3, 4, 5]));
expect(buffer._buffer).toEqual([ expect([...buffer]).toEqual([
viewsMap.get(1), viewsMap.get(1),
viewsMap.get(2), viewsMap.get(2),
viewsMap.get(3), viewsMap.get(3),
@ -138,7 +138,7 @@ describe("BaseViewer", function () {
// while re-ordering the remaining ones correctly. // while re-ordering the remaining ones correctly.
buffer.resize(3, new Set([1, 2, 5])); buffer.resize(3, new Set([1, 2, 5]));
expect(buffer._buffer).toEqual([ expect([...buffer]).toEqual([
viewsMap.get(1), viewsMap.get(1),
viewsMap.get(2), viewsMap.get(2),
viewsMap.get(5), viewsMap.get(5),

11
web/base_viewer.js
View File

@ -99,17 +99,6 @@ class PDFPageViewBuffer {
constructor(size) { constructor(size) {
this.#size = size; this.#size = size;
if (
typeof PDFJSDev === "undefined" ||
PDFJSDev.test("!PRODUCTION || TESTING")
) {
Object.defineProperty(this, "_buffer", {
get() {
return [...this.#buf];
},
});
}
} }
push(view) { push(view) {