Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix an edge-case related to compatibility-values in various AppOptions-methods

Browse Source 
Given how the compatibility-values are being handled, it's not actually possible to override a *truthy* default-value with a *falsy* compatibility-value.
This is a simple oversight on my part, and with modern ECMAScript features this is very easy to support.
This commit is contained in:
Jonas Jenwald 2021-03-19 16:10:31 +01:00
parent 18bc59eb34
commit 7bcfabc43c
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
web/app_options.js
View File

@ -297,7 +297,7 @@ class AppOptions {
} }
const defaultOption = defaultOptions[name]; const defaultOption = defaultOptions[name];
if (defaultOption !== undefined) { if (defaultOption !== undefined) {
return defaultOption.compatibility || defaultOption.value; return defaultOption.compatibility ?? defaultOption.value;
} }
return undefined; return undefined;
} }
@ -329,7 +329,7 @@ class AppOptions {
options[name] = options[name] =
userOption !== undefined userOption !== undefined
? userOption ? userOption
: defaultOption.compatibility || defaultOption.value; : defaultOption.compatibility ?? defaultOption.value;
} }
return options; return options;
} }