Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[TextLayer] Immediately set the padding, rather than checking if it's empty, in expandTextDivs

Browse Source 
In practice it's extremely rare[1] for the padding to be zero in *all* components, hence it seems better to just set it directly rather than creating a temporary variable and checking for the "no padding"-case.

---
[1] In the `tracemonkey.pdf` file that only happens with `0.08%` of all text elements.
This commit is contained in:
Jonas Jenwald 2020-02-11 15:52:36 +01:00
parent 10be0997a7
commit 7b0836ca75
1 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/display/text_layer.js
View File

@ -658,7 +658,6 @@ var renderTextLayer = (function renderTextLayerClosure() {
expand(this); expand(this);
this._bounds = null; this._bounds = null;
} }
const NO_PADDING = "0 0 0 0";
const transformBuf = [], const transformBuf = [],
paddingBuf = []; paddingBuf = [];
@ -701,10 +700,7 @@ var renderTextLayer = (function renderTextLayerClosure() {
paddingBuf.push(0); paddingBuf.push(0);
} }
const padding = paddingBuf.join(" "); div.style.padding = paddingBuf.join(" ");
if (padding !== NO_PADDING) {
div.style.padding = padding;
}
if (transformBuf.length) { if (transformBuf.length) {
div.style.transform = transformBuf.join(" "); div.style.transform = transformBuf.join(" ");
} }