From 5687326046c6eede62578c4891ced5074364ff65 Mon Sep 17 00:00:00 2001 From: Jonas Jenwald Date: Sun, 12 Nov 2023 13:41:10 +0100 Subject: [PATCH] Clean-up the CI workflow a bit After recent PRs the size and scope of the CI workflow is now reduced, and this patch tries to simplify things further. More specifically we can directly specify the gulp-tasks in the workflow, and thus clean-up the `gulpfile` a tiny bit. Note that this will technically be slower, since the tests are now run in series (rather than in parallel), however `gulp externaltest` runs so quickly that it really won't matter in practice. --- .github/workflows/ci.yml | 7 +++++-- gulpfile.mjs | 2 -- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 924c6d81c..a3016315b 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -30,5 +30,8 @@ jobs: - name: Install other dependencies run: npm install - - name: Run tests - run: gulp ci-test + - name: Run external tests + run: gulp externaltest + + - name: Run CLI unit tests + run: gulp unittestcli diff --git a/gulpfile.mjs b/gulpfile.mjs index 61dfecf9c..3103da494 100644 --- a/gulpfile.mjs +++ b/gulpfile.mjs @@ -2436,5 +2436,3 @@ gulp.task("externaltest", function (done) { }); done(); }); - -gulp.task("ci-test", gulp.parallel("externaltest", "unittestcli"));