Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Stop re-loading the Preferences in PDFViewerApplication.open, and remove the BasePreferences.reload method

Browse Source 
Given that the various Preferences are currently, and have been for quite some time, only used when initializing `PDFViewerApplication` re-loading them when a new PDF file is opened in the viewer is essentially a no-op.

Furthermore, with the only usage of `BasePreferences.reload` now gone, the value of that method seems questionable at best. In the event that the functionality is actually needed again, similar to the `ViewHistory`, it'd probably make more sense to simply replace `PDFViewerApplication.preferences` with a new `BasePreferences` instance instead (using e.g. `DefaultExternalServices.createPreferences`).
This commit is contained in:
Jonas Jenwald 2018-07-28 13:14:02 +02:00
parent d6f378fbaf
commit 780cbadcd7
2 changed files with 0 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
web/app.js
View File

@ -635,8 +635,6 @@ let PDFViewerApplication = {
if (this.pdfLoadingTask) {
// We need to destroy already opened document.
return this.close().then(() => {
// Reload the preferences if a document was previously opened.
this.preferences.reload();
// ... and repeat the open() call.
return this.open(file, args);
});

15
web/preferences.js
View File

@ -99,21 +99,6 @@ class BasePreferences {
});
}
/**
* Replace the current preference values with the ones from storage.
* @return {Promise} A promise that is resolved when the preference values
* have been updated.
*/
reload() {
return this._initializedPromise.then(() => {
return this._readFromStorage(this.defaults);
}).then((prefObj) => {
if (prefObj) {
this.prefs = prefObj;
}
});
}
/**
* Set the value of a preference.
* @param {string} name The name of the preference that should be changed.