Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Ensure that CompiledFont.compileGlyph always returns an Array (PR 6141 follow-up)

Browse Source 
PR 6141 changed `CompiledFont.compileGlyph` to, in the general case, return an Array. However, that PR apparenly forgot to update the no-glyph, empty-glyph, and endchar-glyph code-path and a String was still being (incorrectly) returned.

Given the way that `FontFaceObject.getPathGenerator` (on the API side) is implemented, this shouldn't have caused any bugs despite the Worker possible returning unexpected data.
This commit is contained in:
Jonas Jenwald 2018-07-08 21:36:20 +02:00
parent 646d81cd09
commit 775763a091
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/core/font_renderer.js
View File

@ -616,7 +616,7 @@ var FontRendererFactory = (function FontRendererFactoryClosure() {
parse(code);
}
var noop = '';
const NOOP = [];
function CompiledFont(fontMatrix) {
this.compiledGlyphs = Object.create(null);
@ -639,7 +639,7 @@ var FontRendererFactory = (function FontRendererFactoryClosure() {
compileGlyph(code, glyphId) {
if (!code || code.length === 0 || code[0] === 14) {
return noop;
return NOOP;
}
let fontMatrix = this.fontMatrix;