Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove unneeded tweakWebpackOutput usage in the gulpfile (PR 17637 follow-up)

Browse Source 
After the changes in PR 17637 there's no longer any reason to invoke `tweakWebpackOutput` without an argument, since the `__non_webpack_import__` re-writing was moved into the Babel plugin.
This way we can avoid a (little) bit of unnecessary parsing during building.
This commit is contained in:
Jonas Jenwald 2024-02-16 11:35:41 +01:00
parent a83a8d7e4f
commit 751611f690
1 changed files with 7 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
gulpfile.mjs
View File

@ -419,14 +419,10 @@ function checkChromePreferencesFile(chromePrefsPath, webPrefs) {
}
function tweakWebpackOutput(jsName) {
const replacer = [];
if (jsName) {
replacer.push(
" __webpack_exports__ = {};",
" __webpack_exports__ = await __webpack_exports__;"
);
}
const replacer = [
" __webpack_exports__ = {};",
" __webpack_exports__ = await __webpack_exports__;",
];
const regex = new RegExp(`(${replacer.join("|")})`, "gm");
return replace(regex, match => {
@ -466,8 +462,7 @@ function createScriptingBundle(defines, extraOptions = undefined) {
);
return gulp
.src("./src/pdf.scripting.js")
.pipe(webpack2Stream(scriptingFileConfig))
.pipe(tweakWebpackOutput());
.pipe(webpack2Stream(scriptingFileConfig));
}
function createSandboxExternal(defines) {
@ -547,10 +542,7 @@ function createWebBundle(defines, options) {
defaultPreferencesDir: options.defaultPreferencesDir,
}
);
return gulp
.src("./web/viewer.js")
.pipe(webpack2Stream(viewerFileConfig))
.pipe(tweakWebpackOutput());
return gulp.src("./web/viewer.js").pipe(webpack2Stream(viewerFileConfig));
}
function createGVWebBundle(defines, options) {
@ -568,8 +560,7 @@ function createGVWebBundle(defines, options) {
);
return gulp
.src("./web/viewer-geckoview.js")
.pipe(webpack2Stream(viewerFileConfig))
.pipe(tweakWebpackOutput());
.pipe(webpack2Stream(viewerFileConfig));
}
function createComponentsBundle(defines) {