Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #12372 from Snuffleupagus/skip-FBF-makeref

Browse Source 
Skip failing FBF tests, when running `makeref`, in Firefox as well
This commit is contained in:
Tim van der Meij 2020-09-13 14:07:09 +02:00 committed by GitHub
commit 741ce4f7fc
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
test/test.js
View File

@ -467,9 +467,14 @@ function checkFBF(task, results, browser, masterMode) {
continue;
}
if (r0Page.snapshot !== r1Page.snapshot) {
// The FBF tests fail intermittently in Google Chrome when run on the
// bots, ignoring `makeref` failures for now; see https://github.com/mozilla/pdf.js/pull/11491
if (masterMode && /chrom(e|ium)/i.test(browser)) {
// The FBF tests fail intermittently in Firefox and Google Chrome when run
// on the bots, ignoring `makeref` failures for now; see
// - https://github.com/mozilla/pdf.js/pull/12368
// - https://github.com/mozilla/pdf.js/pull/11491
//
// TODO: Figure out why this happens, so that we can remove the hack; see
// https://github.com/mozilla/pdf.js/issues/12371
if (masterMode) {
console.log(
"TEST-SKIPPED | forward-back-forward test " +
task.id +